Open db file in readonly mode for commands which shouldn't update db file #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file Signed-off-by: Benjamin Wang <wachao@vmware.com>
Signed-off-by: Benjamin Wang <wachao@vmware.com>
ptabor
approved these changes
Dec 28, 2022
|
thx @ptabor |
ptabor
added a commit
to ptabor/bbolt
that referenced
this pull request
Dec 30, 2022
I discoved that after change etcd-io#365 the 'bbolt pages' command stopped working. The problem is this check: https://github.com/etcd-io/bbolt/blob/b654ce922133ff49bb385297f30835ca357bac5f/tx.go#L663 that assumes that freepages has been loaded. We can either preload the freepages when opening a RO file: https://github.com/etcd-io/bbolt/blob/b654ce922133ff49bb385297f30835ca357bac5f/db.go#L280-L284 but this would slow-down opening RO files. Thus for now I disable checking whether page is free... Signed-off-by: Piotr Tabor <ptab@google.com>
ptabor
added a commit
to ptabor/bbolt
that referenced
this pull request
Jan 3, 2023
I discoved that after change etcd-io#365 the 'bbolt pages' command stopped working. The problem is this check: https://github.com/etcd-io/bbolt/blob/b654ce922133ff49bb385297f30835ca357bac5f/tx.go#L663 that assumes that freepages has been loaded. We can either preload the freepages when opening a RO file: https://github.com/etcd-io/bbolt/blob/b654ce922133ff49bb385297f30835ca357bac5f/db.go#L280-L284 but this would slow-down opening RO files. Thus for now I disable checking whether page is free... Signed-off-by: Piotr Tabor <ptab@google.com>
ptabor
added a commit
to ptabor/bbolt
that referenced
this pull request
Jan 3, 2023
I discoved that after change etcd-io#365 the 'bbolt pages' command stopped working. The problem is this check: https://github.com/etcd-io/bbolt/blob/b654ce922133ff49bb385297f30835ca357bac5f/tx.go#L663 that assumes that freepages has been loaded. We can either preload the freepages when opening a RO file: https://github.com/etcd-io/bbolt/blob/b654ce922133ff49bb385297f30835ca357bac5f/db.go#L280-L284 but this would slow-down opening RO files. Thus for now I disable checking whether page is free... Signed-off-by: Piotr Tabor <ptab@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all commands shouldn't update the db at all, so we should open the db file in readonly mode.