add PreLoadFreelist to support loading free pages in readonly mode #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptabor
requested changes
Jan 11, 2023
tx.go
Outdated
| @@ -652,6 +652,9 @@ func (tx *Tx) Page(id int) (*PageInfo, error) { | |||
| return nil, nil | |||
| } | |||
|
|
|||
| // Force loading free list if opened in ReadOnly mode. | |||
| tx.db.loadFreelist() | |||
There was a problem hiding this comment.
Thank you for the PR.
Everything looks good to me apart this line. As we discussed in #371 , I find it a risk and indeterminism if within a blocking (exclusive lock) transaction we perform lazy initialization with cost of O(db) size.
I would prefer the call to exit with error that Page(is) is not supported in RO transaction without pre-loaded free pages.
There was a problem hiding this comment.
I think it (db.loadFreelist()) can stay in check:
- it's already O(all pages) operation to perform check
- it's goal it's explicitly to fail in case of any problems is the storage-layer.
There was a problem hiding this comment.
Done. Please take a look at the third commit d2fae80
thx
Signed-off-by: Benjamin Wang <wachao@vmware.com>
Signed-off-by: Benjamin Wang <wachao@vmware.com>
Signed-off-by: Benjamin Wang <wachao@vmware.com>
ptabor
approved these changes
Jan 11, 2023
Thank you for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #372
Signed-off-by: Benjamin Wang wachao@vmware.com