Add bbolt surgery revert-meta-page command
#385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptabor
approved these changes
Jan 16, 2023
|
|
||
| // RevertMetaPageCommand represents the "surgery revert-meta-page" command execution. | ||
| type RevertMetaPageCommand struct { | ||
| baseCommand |
There was a problem hiding this comment.
I think that all surgery commands should operate on SrcPath and DstPath.
I think with the next tool the code will be better structured if we have composition with
a common tool: baseSurgeryToolCommand
There was a problem hiding this comment.
Let me do this when I add the next surgery command.
Signed-off-by: Benjamin Wang <wachao@vmware.com>
|
Just rebased this PR and address review comments. Let's consider to add more unit test later in separate PR. |
ptabor
approved these changes
Jan 16, 2023
Signed-off-by: Benjamin Wang <wachao@vmware.com>
|
Thanks @ptabor for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #370
Note that the first commit is based on #384. Once 384 is merged, I will rebase this PR.