refactor: merge bolt and guts_cli #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I support the direction. Thank you for this refactoring. The plan I was thinking about assumed:
v1.3.5 is already 2.5 year old. |
Actually v1.3.6 was released Jun 2, 2021. I agree to release 1.3.7 firstly. Let me trigger a pipeline to verify bolt in etcd's pipeline, if there is no any issue, then we can tag v1.3.7 |
|
Indeed it was tagged (and used in etcd) but not publised on: https://github.com/etcd-io/bbolt/releases |
|
v1.3.7 is already released, this PR will only target v1.4.0. |
|
@ptabor could you please take a look this PR? I am planning to fix the following two issues on top of this PR, |
Points: 1. There are lots of duplicated definitions between bolt and guts_cli, which is definitely not good. 2. The implementation in guts_cli also has issue, please refer to #391. This refactoring can fix the issue. Signed-off-by: Benjamin Wang <wachao@vmware.com>
Signed-off-by: Benjamin Wang <wachao@vmware.com>
|
Closing this PR, and let me continue to work on #407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Points:
Moved all common definitions into package
internal/common. Majority other changes are basically mechanical changes.Signed-off-by: Benjamin Wang wachao@vmware.com