Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cobra style surgery clear-page-elements command #417

Merged
merged 8 commits into from
Mar 28, 2023
Merged

Add cobra style surgery clear-page-elements command #417

merged 8 commits into from
Mar 28, 2023

Commits on Mar 24, 2023

  1. internal: add function ClearElements in surgeon package 

    Signed-off-by: Benjamin Wang <wachao@vmware.com>
    @ahrtr
    ahrtr committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    9832aff View commit details
    Browse the repository at this point in the history

  2. CMD: add cobra style 'surgery clear-page-elements' command 

    Signed-off-by: Benjamin Wang <wachao@vmware.com>
    @ahrtr
    ahrtr committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    3c3da59 View commit details
    Browse the repository at this point in the history

  3. CMD: add test cases for the 'surgery clear-page-elements' command 

    Signed-off-by: Benjamin Wang <wachao@vmware.com>
    @ahrtr
    ahrtr committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    95576a4 View commit details
    Browse the repository at this point in the history

  4. test: verify the left elements after clear-page-elements operation sh… 

    …ould have the same content

Signed-off-by: Benjamin Wang <wachao@vmware.com>
    @ahrtr
    ahrtr committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    a9a9356 View commit details
    Browse the repository at this point in the history

  5. resolve some minor review comments 

    Signed-off-by: Benjamin Wang <wachao@vmware.com>
    @ahrtr
    ahrtr committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    8902ef9 View commit details
    Browse the repository at this point in the history

  6. test: add more subcases to verify 'surgery-clear-elements' on branch … 

    …page

Signed-off-by: Benjamin Wang <wachao@vmware.com>
    @ahrtr
    ahrtr committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    a0e5e3a View commit details
    Browse the repository at this point in the history

  7. add test case to verify 'surgery-clear-elements' on overflow page 

    Also resolved a bug related to overflow page.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
    @ahrtr
    ahrtr committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    87eed0a View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2023

  1. update command 'surgery clear-page-elements' not to automatically aba… 

    …ndon freelist

Signed-off-by: Benjamin Wang <wachao@vmware.com>
    @ahrtr
    ahrtr committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    74e26be View commit details
    Browse the repository at this point in the history