Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go1.21.1 #566

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Update to go1.21.1 #566

merged 1 commit into from
Sep 15, 2023

Conversation

dusk125
Copy link
Contributor

@dusk125 dusk125 commented Sep 13, 2023

Addresses a to do in etcd-io/etcd#16588

@tjungblu
Copy link
Contributor

/lgtm

finally unsafe.Slice is implemented in go! 🎉

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

freelist.go Outdated Show resolved Hide resolved
internal/common/page.go Outdated Show resolved Hide resolved
internal/common/page.go Outdated Show resolved Hide resolved
internal/common/page.go Outdated Show resolved Hide resolved
Signed-off-by: Allen Ray <alray@redhat.com>
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thx

@ahrtr ahrtr merged commit e682325 into etcd-io:master Sep 15, 2023
9 checks passed
@dusk125 dusk125 deleted the upgrade-go1.21 branch September 15, 2023 20:05
henrybear327 added a commit to henrybear327/bbolt that referenced this pull request Apr 6, 2024
henrybear327 added a commit to henrybear327/bbolt that referenced this pull request Apr 6, 2024
References:
- etcd-io#713
- etcd-io#566

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants