-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to go1.21.1 #566
Merged
Merged
Update to go1.21.1 #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dusk125
force-pushed
the
upgrade-go1.21
branch
3 times, most recently
from
September 14, 2023 15:01
dcb0a9e
to
2298525
Compare
/lgtm finally unsafe.Slice is implemented in go! 🎉 |
jmhbnz
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
serathius
approved these changes
Sep 15, 2023
ahrtr
reviewed
Sep 15, 2023
dusk125
force-pushed
the
upgrade-go1.21
branch
from
September 15, 2023 12:43
2298525
to
a6566fc
Compare
ahrtr
reviewed
Sep 15, 2023
dusk125
force-pushed
the
upgrade-go1.21
branch
from
September 15, 2023 12:48
a6566fc
to
06eb22c
Compare
ahrtr
reviewed
Sep 15, 2023
Signed-off-by: Allen Ray <alray@redhat.com>
dusk125
force-pushed
the
upgrade-go1.21
branch
from
September 15, 2023 13:26
06eb22c
to
18ebb97
Compare
ahrtr
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thx
henrybear327
added a commit
to henrybear327/bbolt
that referenced
this pull request
Apr 6, 2024
References: - etcd-io#713 - etcd-io#566
henrybear327
added a commit
to henrybear327/bbolt
that referenced
this pull request
Apr 6, 2024
References: - etcd-io#713 - etcd-io#566 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a to do in etcd-io/etcd#16588