Prevent MoveBucket from moving a bucket across two different db files
#671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuweid
reviewed
Jan 9, 2024
Elbehery
force-pushed
the
add_move_bucket_protection
branch
from
c1837ee
to
82c3487
Compare
|
Let's add 3 cases below,
|
ahrtr
reviewed
Jan 10, 2024
ahrtr
changed the title
MoveBucket from moving a bucket across two different db files
Elbehery
force-pushed
the
add_move_bucket_protection
branch
2 times, most recently
from
c055ad5
to
ff0b03b
Compare
done 👍🏽 |
Elbehery
commented
Jan 10, 2024
Elbehery
force-pushed
the
add_move_bucket_protection
branch
from
ff0b03b
to
8f4afad
Compare
|
@Elbehery |
Elbehery
force-pushed
the
add_move_bucket_protection
branch
from
8f4afad
to
b64adb8
Compare
fixed .. my bad, forgot to close the second db file :'( deep apologies |
Elbehery
commented
Jan 11, 2024
Elbehery
force-pushed
the
add_move_bucket_protection
branch
from
b64adb8
to
b96ff9c
Compare
Elbehery
commented
Jan 11, 2024
|
i got it, i used the wrong var to in the defer :'( |
Elbehery
force-pushed
the
add_move_bucket_protection
branch
from
b96ff9c
to
f905652
Compare
Elbehery
commented
Jan 11, 2024
fuweid
reviewed
Jan 12, 2024
Elbehery
force-pushed
the
add_move_bucket_protection
branch
from
f905652
to
8d2ef62
Compare
ahrtr
reviewed
Jan 12, 2024
|
@Elbehery Please let's try to get this PR merged today before I create the tag 1.4.0-alpha.0 |
Elbehery
force-pushed
the
add_move_bucket_protection
branch
from
8d2ef62
to
1e43c74
Compare
|
@ahrtr updated & rebased 👍🏽 |
ahrtr
reviewed
Jan 12, 2024
movebucket_test.go
Outdated
| err = dstDB.Update(func(tx *bbolt.Tx) error { | ||
| dstBucket := prepareBuckets(t, tx, dstBucketPath...) | ||
| mErr := srcBucket.MoveBucket([]byte(bucketToMove), dstBucket) | ||
| require.Equal(t, expectedErr, mErr) |
There was a problem hiding this comment.
minor comment:
Suggested change
| require.Equal(t, expectedErr, mErr) | |
| require.Equal(t, errors.ErrDifferentDB, mErr) |
movebucket_test.go
Outdated
| srcBucketPath := []string{"sb1", "sb2"} | ||
| dstBucketPath := []string{"db1", "db2"} | ||
| bucketToMove := "bucketToMove" | ||
| expectedErr := errors.ErrDifferentDB |
There was a problem hiding this comment.
Suggested change
| expectedErr := errors.ErrDifferentDB |
Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
Elbehery
force-pushed
the
add_move_bucket_protection
branch
from
1e43c74
to
7555f26
Compare
|
@ahrtr updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more test to move bucket feature
Refer to #635 (comment)
cc @ahrtr @fuweid