Add basic XFS powerfailure tests #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjungblu
commented
Mar 7, 2024
tjungblu
force-pushed
the
xfs
branch
3 times, most recently
from
edfbaf8
to
3d104a9
Compare
tjungblu
force-pushed
the
xfs
branch
6 times, most recently
from
257e8cf
to
fe3539f
Compare
ahrtr
reviewed
Mar 12, 2024
| func TestRestartFromPowerFailureXFS(t *testing.T) { | ||
| for _, tc := range []struct { | ||
| name string | ||
| du time.Duration |
There was a problem hiding this comment.
Its value is always 5s.
Suggested change
| du time.Duration |
Comment on lines
132
to
130
| mkfsOpt: "-m bigtime=1,finobt=1,rmapbt=0,reflink=1 -i sparse=1 -l lazy-count=1", | ||
| // openshift also supplies seclabel,relatime,prjquota on RHEL, but that's not supported on our CI | ||
| // prjquota is only unsupported on our ARM runners. | ||
| fsMountOpt: "rw,attr2,inode64,logbufs=8,logbsize=32k", |
There was a problem hiding this comment.
Please provide a link to the guide of XFS, including detailed explanation to all the parameters.
There was a problem hiding this comment.
I've left a mention of the man commands, not sure it makes sense to link documentation to an online manual.
ahrtr
reviewed
Mar 12, 2024
| mkfsOpt: "-m bigtime=1,finobt=1,rmapbt=0,reflink=1 -i sparse=1 -l lazy-count=1", | ||
| // openshift also supplies seclabel,relatime,prjquota on RHEL, but that's not supported on our CI | ||
| // prjquota is only unsupported on our ARM runners. | ||
| // You can find more information in either the man page with `man xfs` or `man mkfs.xfs`. |
There was a problem hiding this comment.
Suggested change
| // You can find more information in either the man page with `man xfs` or `man mkfs.xfs`. | |
| // You can find more information in either the man page with `man xfs` or `man mkfs.xfs`. | |
| // Also refer to https://man7.org/linux/man-pages/man8/mkfs.xfs.8.html. |
There was a problem hiding this comment.
whatever you prefer, I personally would avoid it due to link rot....
There was a problem hiding this comment.
Some parameters (e.g. -m bigtime=1) used in this PR are not supported by old version of mkfs.xfs. Probably my linux VM is too old (3.10).
Providing a link should be better.
- The link should be relatively stable.
- When you google it, you will find lots of links, not all links are correct (e.g. https://linux.die.net/man/8/mkfs.xfs doesn't include all parameters/flags). So providing a referenced link should be better. Even it rots, it also provides a reference on which link returned by google is correct.
ahrtr
approved these changes
Mar 12, 2024
|
thanks folks, I'll update the PR throughout my morning today |
|
done, PTAL again. |
This also introduces mkfs options, in case we need to accomodate for non-default parameters here in the future. Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
ahrtr
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also introduces mkfs options, in case we need to accomodate for non-default parameters here in the future.