Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for 1.4.0-alpha.1 #745

Merged
merged 1 commit into from
May 3, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented May 3, 2024

@Elbehery
Copy link
Member

Elbehery commented May 3, 2024

LGTM

@ahrtr ahrtr force-pushed the changelog_1.4-alpha.1_20240503 branch 2 times, most recently from 2199cb8 to d4e3b7a Compare May 3, 2024 14:25
CHANGELOG/CHANGELOG-1.4.md Outdated Show resolved Hide resolved
@ahrtr ahrtr force-pushed the changelog_1.4-alpha.1_20240503 branch from d4e3b7a to fde632a Compare May 3, 2024 14:40
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two suggestions, other than that LGTM. Thanks, @ahrtr.

CHANGELOG/CHANGELOG-1.4.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-1.4.md Outdated Show resolved Hide resolved
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@ahrtr ahrtr force-pushed the changelog_1.4-alpha.1_20240503 branch from fde632a to dc3e157 Compare May 3, 2024 15:09
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr ahrtr merged commit 30530e3 into etcd-io:main May 3, 2024
16 checks passed
@ahrtr ahrtr deleted the changelog_1.4-alpha.1_20240503 branch June 24, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants