Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.3] backport make build target and go bench output #802

Merged
merged 1 commit into from
Aug 1, 2024
Merged

[1.3] backport make build target and go bench output #802

merged 1 commit into from
Aug 1, 2024

Conversation

tjungblu
Copy link
Contributor

@tjungblu tjungblu commented Jul 31, 2024 •
edited
Loading

manual backport of #765 and partially #664, to make the nightly benchmark work

failure for reference: https://github.com/etcd-io/bbolt/actions/runs/10174478637/job/28140291652#step:5:4094

@tjungblu
ensure build and bench output in 3.5
138cbb3 
manual backport of etcd-io#765 and partially etcd-io#664, to make the nightly
benchmark work

Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
@tjungblu tjungblu marked this pull request as ready for review July 31, 2024 11:29
ahrtr
ahrtr approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @tjungblu

cc @ivanvc

@ivanvc
Copy link
Member

ivanvc commented Aug 1, 2024

/retitle [1.3] ensure GitHub actions build and bench output

@k8s-ci-robot k8s-ci-robot changed the title ensure build and bench output in 3.5 [1.3] ensure GitHub actions build and bench output Aug 1, 2024
@ivanvc
Copy link
Member

ivanvc commented Aug 1, 2024

/retitle [1.3] backport make build target and go bench output

@k8s-ci-robot k8s-ci-robot changed the title [1.3] ensure GitHub actions build and bench output [1.3] backport make build target and go bench output Aug 1, 2024
ivanvc
ivanvc approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @tjungblu.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, ivanvc, tjungblu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 14c8aaf into etcd-io:release-1.3 Aug 1, 2024
9 checks passed
@tjungblu tjungblu deleted the nighty_bench_3.5 branch August 1, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanvc ivanvc ivanvc approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
size/M
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tjungblu @ivanvc @k8s-ci-robot @ahrtr