Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3] tests/robustness: switch to kill if no panic after 10sec #817

Conversation

fuweid
Copy link
Member

@fuweid fuweid commented Aug 9, 2024

If file doesn't grow in 10 sec, bbolt won't trigger the following errors:

  • lackOfDiskSpace
  • mapError
  • resizeFileError
  • unmapError

We should switch to kill instead of waiting for panic. In order to trigger these errors, we should increase value size to 512.

(cherry picked from commit 49eb212)

Fixes: #816 (comment)

If file doesn't grow in 10 sec, bbolt won't trigger the following
errors:

* lackOfDiskSpace
* mapError
* resizeFileError
* unmapError

We should switch to kill instead of waiting for panic. In order to
trigger these errors, we should increase value size to 512.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
(cherry picked from commit 49eb212)
Signed-off-by: Wei Fu <fuweid89@gmail.com>
@fuweid
Copy link
Member Author

fuweid commented Aug 9, 2024

ping @ahrtr @tjungblu

@tjungblu
Copy link
Contributor

tjungblu commented Aug 9, 2024

/lgtm

@ahrtr
Copy link
Member

ahrtr commented Aug 9, 2024

Thanks for the quick fix.

Do you know why your PR #816 did not fail, but the release-1.3 failed after merging your PR?

@fuweid
Copy link
Member Author

fuweid commented Aug 9, 2024

Thanks for the quick fix.

Do you know why your PR #816 did not fail, but the release-1.3 failed after merging your PR?

The failpoint was randomly picked and some failpoints only trigger panic during resizing. If the test hit the timing, it will pass.
If not, it won't panic in 10 seconds. This patch is to force to kill the process if it's not panic in time.

@ahrtr
Copy link
Member

ahrtr commented Aug 9, 2024

The failpoint was randomly picked and some failpoints only trigger panic during resizing

thx for the clarification.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, fuweid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 01f29e9 into etcd-io:release-1.3 Aug 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants