Skip to content

Commit

Permalink
*: keep tombstone if revision == compactAtRev
Browse files Browse the repository at this point in the history
Before this patch, the tombstone can be deleted if its revision is equal
compacted revision. It causes that the watch subscriber won't get this
DELETE event. Based on Compact API[1], we should keep tombstone revision
if it's not less than the compaction revision.

> CompactionRequest compacts the key-value store up to a given revision.
> All superseded keys with a revision less than the compaction revision
> will be removed.

[1]: https://etcd.io/docs/latest/dev-guide/api_reference_v3/

Signed-off-by: Wei Fu <fuweid89@gmail.com>
(cherry picked from commit bbdc941)
Signed-off-by: Wei Fu <fuweid89@gmail.com>
  • Loading branch information
fuweid committed Aug 20, 2024
1 parent 4b7c1f4 commit 801bcf0
Show file tree
Hide file tree
Showing 4 changed files with 501 additions and 95 deletions.
Loading

0 comments on commit 801bcf0

Please sign in to comment.