Merge pull request #10762 from FrozenAndrey/fix#10747

etcdmain: fix ignoring of ETCD_CONFIG_FILE env variable
etcd-io · Jun 8, 2019 · ea70731 · ea70731
2 parents f6a9ebe + 14c5eaa
commit ea70731
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/etcdmain/config.go b/etcdmain/config.go
@@ -284,6 +284,14 @@ func (cfg *config) parse(arguments []string) error {
 	}
 
 	var err error
+
+	// This env variable must be parsed separately
+	// because we need to determine whether to use or
+	// ignore the env variables based on if the config file is set.
+	if cfg.configFile == "" {
+		cfg.configFile = os.Getenv(flags.FlagToEnv("ETCD", "config-file"))
+	}
+
 	if cfg.configFile != "" {
 		err = cfg.configFromFile(cfg.configFile)
 		if lg := cfg.ec.GetLogger(); lg != nil {