Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace github.com/form3tech-oss/jwt-go with https://github.com/golang-jwt/jwt #13254

Closed
Haimantika opened this issue Jul 29, 2021 · 2 comments
Closed

Replace github.com/form3tech-oss/jwt-go with https://github.com/golang-jwt/jwt #13254

Haimantika opened this issue Jul 29, 2021 · 2 comments
Labels
stale

Comments

@Haimantika
Copy link
Contributor

Haimantika commented Jul 29, 2021 •
edited
Loading

The maintained fork of https://github.com/form3tech-oss/jwt-go seems now to be https://github.com/golang-jwt/jwt, we might need to make some changes accordingly to:

etcd/server/go.mod

Line 9 in 4cbb949

github.com/form3tech-oss/jwt-go v3.2.3+incompatible

For more information on this please refer to kubernetes/kubernetes#104007
@asaha123 asaha123 mentioned this issue Aug 2, 2021
Closed
@naveensrinivasan naveensrinivasan mentioned this issue Sep 15, 2021
Merged
10 tasks
naveensrinivasan added a commit to naveensrinivasan/lnd that referenced this issue Sep 16, 2021
@naveensrinivasan
mod : Replace for OSV GO-2020-0017 JWT
8b4bbfb 
The github.com/dgrijalva/jwt-go is no longer maintained
has this CVE GHSA-w73w-5m7g-f7qc

But it is being used by etcd-io/etcd#13254
which `lnd` uses.

The https://github.com/golang-jwt/jwt/releases/tag/v3.2.1 is a fork of
the same version which was 3.2.0 with the security fix.
@ysksuzuki
Copy link

etcd 3.4 still depends on github.com/dgrijalva/jwt-go v3.2.0 which has the CVE GHSA-w73w-5m7g-f7qc.
https://github.com/etcd-io/etcd/blob/release-3.4/go.mod#L12

Is it OK to send a PR to update github.com/dgrijalva/jwt-go to github.com/golang-jwt/jwt on release-3,4 branch?

@ysksuzuki ysksuzuki mentioned this issue Oct 1, 2021
Merged
@stale
Copy link

stale bot commented Dec 30, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 30, 2021
@stale stale bot closed this as completed Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ysksuzuki @Haimantika