Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestCtlV3AuthGracefulDisable always fails in Coverage workflow #14926

Closed
ahrtr opened this issue Dec 11, 2022 · 6 comments · Fixed by #14999
Closed

TestCtlV3AuthGracefulDisable always fails in Coverage workflow #14926

ahrtr opened this issue Dec 11, 2022 · 6 comments · Fixed by #14999

Comments

@ahrtr
Copy link
Member

ahrtr commented Dec 11, 2022

Which github workflows are flaking?

Coverage

Which tests are flaking?

TestCtlV3AuthGracefulDisable

Github Action link

https://github.com/etcd-io/etcd/actions/runs/3666035308/jobs/6197499132

Reason for failure (if possible)

   ctl_v3_auth_test.go:170: match not found.  Set EXPECT_DEBUG for more info Errs: [unexpected exit code [1] after running [/home/runner/work/etcd/etcd/bin/etcd_test grpc-proxy start --listen-addr localhost:20003 --endpoints http://localhost:20000 --advertise-client-url  --data-dir /tmp/TestCtlV3AuthGracefulDisable2565698461/002 --cert /home/runner/work/etcd/etcd/tests/fixtures/client-nocn.crt --key /home/runner/work/etcd/etcd/tests/fixtures/client-nocn.key.insecure --cacert /home/runner/work/etcd/etcd/tests/fixtures/ca.crt --client-crl-file /home/runner/work/etcd/etcd/tests/fixtures/revoke.crl -test.coverprofile=e2e.1670591664227553953.coverprofile -test.outputdir=/home/runner/work/etcd/etcd/covdir/e2e_proxy]], last lines:
        listen tcp 127.0.0.1:20003: bind: address already in use
        
    testutil.go:56: ---> Test failed: test timed out after 15s
    testutil.go:57: goroutine 558 [running]:
        go.etcd.io/etcd/client/pkg/v3/testutil.FatalStack(0xc0000164e0, {0xc000042738, 0x18})
        	/home/runner/work/etcd/etcd/client/pkg/testutil/testutil.go:55 +0x52
        go.etcd.io/etcd/tests/v3/e2e.runCtlTest(_, _, _, {0xc0000164e0, {0x0, 0x0}, {0x0, {0x0, 0x0}, {0x0, ...}, ...}, ...})
        	/home/runner/work/etcd/etcd/tests/e2e/ctl_v3_test.go:268 +0x29c
        go.etcd.io/etcd/tests/v3/e2e.testCtlWithOffline(0xc0000164e0, 0xec42d8?, 0x0, {0x0, 0x0, 0x0?})
        	/home/runner/work/etcd/etcd/tests/e2e/ctl_v3_test.go:240 +0x45b
        go.etcd.io/etcd/tests/v3/e2e.testCtl(...)
        	/home/runner/work/etcd/etcd/tests/e2e/ctl_v3_test.go:205
        go.etcd.io/etcd/tests/v3/e2e.TestCtlV3AuthGracefulDisable(0xc000064f60?)
        	/home/runner/work/etcd/etcd/tests/e2e/ctl_v3_auth_test.go:33 +0x29
        testing.tRunner(0xc0000164e0, 0xec3e60)
        	/opt/hostedtoolcache/go/1.19.4/x64/src/testing/testing.go:1446 +0x10b
        created by testing.(*T).Run
        	/opt/hostedtoolcache/go/1.19.4/x64/src/testing/testing.go:1493 +0x35f

Anything else we need to know?

No response

@ahrtr
Copy link
Member Author

ahrtr commented Dec 11, 2022

cc @tjungblu

@tjungblu
Copy link
Contributor

thanks @ahrtr, seems it's having trouble with already running processes taking that port?

last lines:
listen tcp 127.0.0.1:20003: bind: address already in use

@ahrtr
Copy link
Member Author

ahrtr commented Dec 12, 2022

seems it's having trouble with already running processes taking that port?

Yes, could you or anyone take a deep dive into the issue?

@tjungblu
Copy link
Contributor

sure, I can take a look if no one else wants to volunteer :)

@fuweid
Copy link
Member

fuweid commented Dec 12, 2022

@ahrtr please assign it to me. I would like to handle this. Thanks!

@tjungblu
Copy link
Contributor

Thanks and good luck, @fuweid!

fuweid added a commit to fuweid/etcd that referenced this issue Dec 15, 2022
We should call Wait for grpc-proxy process stop before start. Otherwise,
the tcp port won't be released.

Fixes: etcd-io#14926

Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid added a commit to fuweid/etcd that referenced this issue Dec 16, 2022
We should call Wait for grpc-proxy process stop before start. Otherwise,
the tcp port won't be released.

Fixes: etcd-io#14926

Signed-off-by: Wei Fu <fuweid89@gmail.com>
wafuwafu13 pushed a commit to wafuwafu13/etcd that referenced this issue Jan 5, 2023
We should call Wait for grpc-proxy process stop before start. Otherwise,
the tcp port won't be released.

Fixes: etcd-io#14926

Signed-off-by: Wei Fu <fuweid89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants