Nominating @fuweid as etcd reviewer

[jmhbnz]

Who would you like to nominate?

I would like to propose @fuweid for role of reviewer.

@fuweid has demonstrated excellent knowledge in crucial areas of both etcd and grpc-gateway/protobuf. They were instrumental in landing #16595 (refer discussion in #16454).

They have reviewed over 150 PRs and authored over 60 merged pr's.

@fuweid's technical knowledge is a tremendous asset to the project and their participation as the fourth most active contributor to etcd makes them an excellent candidate for an etcd reviewer.

Requirements

• I have reviewed the community membership guidelines
• The members are actively contributing to 1 or more etcd subprojects
• The members are being sponsored by two current reviewers or a current maintainer.

How do the new members meet the regular active contribution requirements?

• member for at least 3 months. Joined April 2023.

• Primary reviewer for at least 5 PRs to the codebase:

  • Upgrade grpc-gateway from v1 to v2 #16595
  • test: de-flake test case TestV3WatchProgressOnMemberRestart #16547
  • server: Separate txnRead from txnWrite #16371
  • pkg/expect: avoid hardcoding when checking ErrProcessDone #16252
  • Robustness etcd traffic client #16092

• Reviewed or contributed at least 20 substantial PRs to the codebase, examples:

  • Improving testing compute capacity through large runners *: enable ubuntu-latest-8-cores runner for amd64 robustness workflow #16440
  • Making test output easier to understand by reducing noise tests/*: redirect metrics into file #16439
  • Improving robustness test suite tests/robustness: enhance compact failpoint #16310
  • Adding features to our benchmarking tooling tools/benchmark: support --count-only for range #16196
  • Deflaking complex tests (deflake: mvcc storage ut #15489, [3.4] pkg/ioutil: deflake TestPageWriterRandom #16558, server/storage/mvcc: deflake TestHashKVWhenCompacting #16549, pkg/ioutil: deflake TestPageWriterRandom #16268, pkg/expect: fix data race #16173, tests: deflake TestKVDelete/ClientAutoTLS #15920, tests: deflake TestV3WatchRestoreSnapshotUnsync #15667)
  • Finding and fixing race in grpc server start code server/embed: fix data race when start insecure grpc #15509
  • Finding issue with closing listeners Allow user to separate http and grpc server #15446 (comment)
  • Finding issue with etcd scripts and rewriting them to strict mode greatly improving their reliability and quality chore: introduce strict bash mode for scripts,.github #15519
  • Significantly overhauling etcd codebase linting (*: fix revive linter #16634, *: fix goimports linter #16628, *: fix staticcheck lint #16626, *: fix govet-shadow lint #16608, *: fix ineffassign lint #16605, *: fix nakedret lint #16601)

• Knowledgeable about the codebase.

  • @fuweid is a project go to person for gRPC and protobuf
  • @fuweid has contributed to etcd robustness testing suite which is crucial knowledge moving forward
  • @fuweid has significantly improved etcd codebase quality recently with linting overhauls

• Sponsored by two active maintainers.

  • @spzala, IBM
  • @ahrtr, VMware

• Sponsors must be from multiple member companies to demonstrate integration across community.

[fuweid]

@jmhbnz Thanks for filing this proposal! Thanks team!
Looking forward to contributing more contributions. Thanks for the support!

[ahrtr]

Well deserved! Thanks for your great contribution! @fuweid

cc @mitake @ptabor @serathius @spzala @wenjiaswe

[serathius]

LGTM

[tjungblu]

Well deserved, welcome to the club :)

[wenjiaswe]

lgtm. Thank you @fuweid for your contribution!

[ahrtr]

There are supports from majority maintainers & chairs.

@fuweid please raise a PR to add yourself into OWNERS and MAINTAINERS.

[fuweid]

Thanks @serathius @ahrtr @wenjiaswe @jmhbnz @tjungblu for the support!

cc @ahrtr #16652

[wenjiaswe]

Congratulations!

[ahrtr]

Completed in #16652