-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-write rw-heatmaps tool in golang #17404
Comments
/assign @ivanvc |
@jmhbnz: GitHub didn't allow me to assign the following users: ivanvc. Note that only etcd-io members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Leaving a comment so you can assign it to me, or perhaps prow will do it if I try? |
/assign |
Hi @jmhbnz, after reviewing today's triage meeting notes, I see this issue was discussed. As agreed in the meeting (the recording is not on YouTube yet), #15060 should be closed when I implement the line charts (hopefully soon). In my opinion, this issue can be closed now, but @ahrtr may also want to weigh in. |
Closed. |
OOPS, I misread the comment above, I closed the PR instead of this issue. I am good as long as eventually we can integrate the line chart. Please feel free to close this issue if you want. |
What would you like to be added?
Sub task under #16467
We currently have https://github.com/etcd-io/etcd/tree/main/tools/rw-heatmaps as a helpful custom utility for qualifying etcd performance visually.
Unfortunately the current tooling is written in python which doesn't make sense for etcd as a golang project and introduces challenges keeping the tool maintained.
There was a historic stale attempt at this rewrite #15060 however this changed the existing tool functionality so was not a simple rewrite and did not get consensus to proceed.
@ivanvc has begun work on a newer rewrite that does not introduce any new features and would give us a clear pathway forward.
Why is this needed?
We need well maintained tooling to regularly qualify the performance of etcd.
The text was updated successfully, but these errors were encountered: