Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample: correct directive name #10018

Merged
merged 1 commit into from
Aug 16, 2018
Merged

sample: correct directive name #10018

merged 1 commit into from
Aug 16, 2018

Conversation

ymmt2005
Copy link
Contributor

@ymmt2005 ymmt2005 commented Aug 16, 2018

Both "client-transport-security" and "peer-transport-security"
is mapped to Go struct embed.securityConfig.

https://github.com/coreos/etcd/blob/master/embed/config.go#L345

Field for client certificate authentication is tagged as client-cert-auth,
but it is misspelled in peer-transport-security section.

Both "client-transport-security" and "peer-transport-security"
is mapped to Go struct embed.securityConfig.

Field for client certificate authentication is tagged as
"client-cert-auth", but it is misspelled in "peer-transport-security"
section.
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@gyuho gyuho merged commit 6890a9e into etcd-io:master Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants