Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver/api/rafthttp: clarify "became inactive" warning #10024

Merged
merged 1 commit into from
Aug 25, 2018

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Aug 18, 2018

"became inactive" is not a clear warning, when what's actually happening is failure to send HTTP requests.

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@codecov-io
Copy link

Codecov Report

Merging #10024 into master will decrease coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10024      +/-   ##
==========================================
- Coverage   69.37%   69.13%   -0.24%     
==========================================
  Files         386      386              
  Lines       36057    36060       +3     
==========================================
- Hits        25013    24930      -83     
- Misses       9243     9338      +95     
+ Partials     1801     1792       -9
Impacted Files Coverage Δ
etcdserver/api/rafthttp/peer_status.go 89.47% <100%> (ø) ⬆️
etcdserver/api/v3rpc/interceptor.go 39.47% <0%> (-57.85%) ⬇️
clientv3/balancer/grpc1.7-health.go 46.22% <0%> (-12.8%) ⬇️
proxy/grpcproxy/register.go 69.44% <0%> (-11.12%) ⬇️
pkg/netutil/netutil.go 63.11% <0%> (-6.56%) ⬇️
proxy/grpcproxy/watcher.go 85.71% <0%> (-4.09%) ⬇️
proxy/httpproxy/director.go 80% <0%> (-2.86%) ⬇️
clientv3/concurrency/election.go 79.52% <0%> (-2.37%) ⬇️
etcdserver/api/v3rpc/watch.go 73.52% <0%> (-2.29%) ⬇️
integration/bridge.go 70.22% <0%> (-1.53%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6890a9e...156ff64. Read the comment docs.

@spzala
Copy link
Member

spzala commented Aug 23, 2018

lgtm

@hexfusion hexfusion merged commit af85949 into etcd-io:master Aug 25, 2018
@gyuho gyuho deleted the became-inactive branch August 25, 2018 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants