Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raft: provide protection against unbounded Raft log growth #10167

Merged
merged 3 commits into from
Oct 14, 2018
Merged

raft: provide protection against unbounded Raft log growth #10167

merged 3 commits into from
Oct 14, 2018

Commits on Oct 14, 2018

  1. raft: provide protection against unbounded Raft log growth 

    The suggested pattern for Raft proposals is that they be retried
periodically until they succeed. This turns out to be an issue
when a leader cannot commit entries because the leader will continue
to append re-proposed entries to its log without committing anything.
This can result in the uncommitted tail of a leader's log growing
without bound until it is able to commit entries.

This change add a safeguard to protect against this case where a
leader's log can grow without bound during loss of quorum scenarios.
It does so by introducing a new, optional ``MaxUncommittedEntriesSize
configuration. This config limits the max aggregate size of uncommitted
entries that may be appended to a leader's log. Once this limit
is exceeded, proposals will begin to return ErrProposalDropped
errors.

See cockroachdb/cockroach#27772
    @nvanbenschoten
    nvanbenschoten committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    f89b06d View commit details
    Browse the repository at this point in the history

  2. raft: Fix spelling in doc.go

    @nvanbenschoten
    nvanbenschoten committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    7be7ac5 View commit details
    Browse the repository at this point in the history

  3. raft: Fix comment on sendHeartbeat

    @nvanbenschoten
    nvanbenschoten committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    73c20cc View commit details
    Browse the repository at this point in the history