Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: api/v2v3: add initial tests #10622

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Conversation

philips
Copy link
Contributor

@philips philips commented Apr 10, 2019

Add a bunch of tests on fundamental operation of Create/Set/Delete.

Context: I want to use this package to run the discovery service against
the v3 storage backend. The limited functionality already implemented
should be sufficient to do this.
coreos/discovery.etcd.io#52

@codecov-io
Copy link

codecov-io commented Apr 10, 2019

Codecov Report

Merging #10622 into master will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10622      +/-   ##
==========================================
+ Coverage   71.62%   71.98%   +0.35%     
==========================================
  Files         393      393              
  Lines       36571    36628      +57     
==========================================
+ Hits        26194    26365     +171     
+ Misses       8538     8405     -133     
- Partials     1839     1858      +19
Impacted Files Coverage Δ
proxy/grpcproxy/metrics.go 25% <0%> (-75%) ⬇️
pkg/fileutil/read_dir.go 91.3% <0%> (-8.7%) ⬇️
clientv3/leasing/cache.go 87.77% <0%> (-3.89%) ⬇️
etcdmain/grpc_proxy.go 59.92% <0%> (-2.69%) ⬇️
clientv3/balancer/balancer.go 84.49% <0%> (-2.33%) ⬇️
etcdserver/api/v2http/client.go 85.51% <0%> (-1.21%) ⬇️
etcdserver/server.go 74.53% <0%> (-0.51%) ⬇️
etcdserver/api/membership/cluster.go 77.5% <0%> (-0.46%) ⬇️
clientv3/watch.go 90.92% <0%> (-0.22%) ⬇️
etcdserver/api/v3election/election.go 66.66% <0%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc08c1b...f17c038. Read the comment docs.

Add a bunch of tests on fundamental operation of Create/Set/Delete.

Context: I want to use this package to run the discovery service against
the v3 storage backend. The limited functionality already implemented
should be sufficient to do this.
coreos/discovery.etcd.io#52
@philips philips changed the title etcdserver: api/v2v3: fix isRoot and add initial tests etcdserver: api/v2v3: add initial tests Apr 10, 2019
@gyuho
Copy link
Contributor

gyuho commented Jul 25, 2019

Manually tested, and it passed with current master. LGTM. Thanks.

@gyuho gyuho merged commit 388d15f into etcd-io:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants