Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update grpc-go to v1.20.0 #10624

Closed
wants to merge 1 commit into from
Closed

Conversation

aanm
Copy link

@aanm aanm commented Apr 10, 2019

This version includes patch from
grpc/grpc-go#2695 which
fixes #9956

Signed-off-by: André Martins aanm90@gmail.com

@jingyih
Copy link
Contributor

jingyih commented Apr 15, 2019

cc @jpbetz

@aanm
Copy link
Author

aanm commented Apr 23, 2019

cc @hexfusion

@gyuho
Copy link
Contributor

gyuho commented Apr 23, 2019

Whenever we upgrade gRPC, a lot of things break... I will investigate more in May.

This version includes patch from
grpc/grpc-go#2695 which
fixes etcd-io#9956

Signed-off-by: André Martins <aanm90@gmail.com>
@jingyih
Copy link
Contributor

jingyih commented Jul 3, 2019

Since we are bumping up the grpc version, can we try to bump the version to 1.22? We need to pick up grpc/grpc-go#2777 which is included in 1.21 and above to fix #10087.

@gyuho
Copy link
Contributor

gyuho commented Jul 3, 2019

@jingyih I will be working on gRPC balancer fix, with gRPC 1.22 bump up. Will start working on it after July 4

@hexfusion
Copy link
Contributor

@gyuho I can dedicate cycles to assist in this effort as well, please touch base so we can coordinate.

@gyuho
Copy link
Contributor

gyuho commented Jul 8, 2019

@hexfusion Let's sync up later next week. The changes that I need in clientv3 needs latest gRPC. So, I will bundle them in my later PR.

@gyuho gyuho closed this Jul 8, 2019
@gyuho
Copy link
Contributor

gyuho commented Jul 8, 2019

Closing, to use gRPC 1.22.0

@pires
Copy link

pires commented Jul 11, 2019

@gyuho would be great to have a linked issue or PR to keep track of the follow-up.

@gyuho
Copy link
Contributor

gyuho commented Jul 11, 2019

@pires Yes, I will keep posting updates here as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3.3.7 panic: send on closed channel
5 participants