-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue that metric db_compaction_total_duration_milliseconds is always 0 #10646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the fix! Can you change the title of the commit to |
yingnanzhang666
force-pushed
the
metrics_db_compaction
branch
from
April 16, 2019 02:33
91518b9
to
c5cb550
Compare
@jingyih commit title is changed as your recommendation. thx. |
lgtm |
We should probably backport this. @jpbetz |
This was referenced Apr 17, 2019
Agreed. Here are the backports: |
jpbetz
added a commit
to jpbetz/etcd
that referenced
this pull request
Apr 18, 2019
jpbetz
added a commit
that referenced
this pull request
Apr 18, 2019
…-release-3.3 Automated cherry pick of #10646
jpbetz
added a commit
that referenced
this pull request
Apr 18, 2019
…-release-3.2 Automated cherry pick of #10646
jpbetz
added a commit
that referenced
this pull request
Apr 18, 2019
…-release-3.1 Automated cherry pick of #10646
jpbetz
added a commit
that referenced
this pull request
Apr 18, 2019
CHANGELOG: update changelogs for backport of PR #10646
jingyih
added a commit
to jingyih/etcd
that referenced
this pull request
Apr 20, 2019
gyuho
added a commit
that referenced
this pull request
Apr 23, 2019
CHANGELOG: update CHANGELOG-3.4 from #10646
MartinWeindel
pushed a commit
to MartinWeindel/etcd
that referenced
this pull request
Jun 12, 2019
MartinWeindel
pushed a commit
to MartinWeindel/etcd
that referenced
this pull request
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defer dbCompactionTotalMs.Observe(float64(time.Since(totalStart) / time.Millisecond))
Here, it will calculate
float64(time.Since(totalStart) / time.Millisecond)
when call defer directly and push into function stack, so the duration is quite small, less than 1 millisecond, so this value is always zero.