Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/e2e: initialize UserAddOptions{} field in testV3CurlAuth() #10800

Merged
merged 1 commit into from
Jun 7, 2019
Merged

tests/e2e: initialize UserAddOptions{} field in testV3CurlAuth() #10800

merged 1 commit into from
Jun 7, 2019

Conversation

mitake
Copy link
Contributor

@mitake mitake commented Jun 6, 2019 •
edited
Loading

@mitake mitake mentioned this pull request Jun 6, 2019
Merged
@mitake mitake requested a review from jingyih June 6, 2019 14:19
@jingyih
Copy link
Contributor

jingyih commented Jun 6, 2019

LGTM.

For context, this PR fixes e2e tests TestV3CurlAuth and TestV3CurlAuthClientTLSCertAuth.

@jingyih jingyih mentioned this pull request Jun 7, 2019
Closed
@xiang90 xiang90 merged commit 805b918 into etcd-io:master Jun 7, 2019
@jingyih jingyih mentioned this pull request Jun 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingyih jingyih Awaiting requested review from jingyih

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitake @jingyih @xiang90