Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clientv3: fix secure endpoint failover, refactor with gRPC 1.22 upgrade #10911

Merged
merged 12 commits into from
Jul 26, 2019
Merged

clientv3: fix secure endpoint failover, refactor with gRPC 1.22 upgrade #10911

merged 12 commits into from
Jul 26, 2019

Commits on Jul 26, 2019

  1. clientv3: do not use pointer to TransportCredentials interface 

    Interface in Go is already reference

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
    @gyuho
    gyuho committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    12ab2ee View commit details
    Browse the repository at this point in the history

  2. vendor: upgrade grpc-go to v1.22.1 

    Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
    @gyuho
    gyuho committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    4707d7a View commit details
    Browse the repository at this point in the history

  3. clientv3/credential: implement grpc/credentials.Bundle 

    Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
    @gyuho
    gyuho committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    324c876 View commit details
    Browse the repository at this point in the history

  4. clientv3: use new "credentials" package 

    Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
    @gyuho
    gyuho committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    db7231a View commit details
    Browse the repository at this point in the history

  5. etcdserver/api/v3rpc: use new "credentials" package 

    Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
    @gyuho
    gyuho committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    7cbe2f5 View commit details
    Browse the repository at this point in the history

  6. embed: use new "credentials" package 

    Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
    @gyuho
    gyuho committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    a6b105a View commit details
    Browse the repository at this point in the history

  7. clientv3/credentials: set dial target "Authority" with target address 

    Overwrite authority when it's IP.

When user dials with "grpc.WithDialer", "grpc.DialContext" "cc.parsedTarget"
update only happens once. This is problematic, because when TLS is enabled,
retries happen through "grpc.WithDialer" with static "cc.parsedTarget" from
the initial dial call.
If the server authenticates by IP addresses, we want to set a new endpoint as
a new authority. Otherwise
"transport: authentication handshake failed: x509: certificate is valid for 127.0.0.1, 192.168.121.180, not 192.168.223.156"
when the new dial target is "192.168.121.180" whose certificate host name is also "192.168.121.180"
but client tries to authenticate with previously set "cc.parsedTarget" field "192.168.223.156"

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
    @gyuho
    gyuho committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    db61ee1 View commit details
    Browse the repository at this point in the history

  8. clientv3: move auth token credential to "credentials" package 

    Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
    @gyuho
    gyuho committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    3dc00ab View commit details
    Browse the repository at this point in the history

  9. clientv3/balancer: refactor 

    refactor + remove unused

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
    @gyuho
    gyuho committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    8c7c6ec View commit details
    Browse the repository at this point in the history

  10. clientv3/integration: give more time for balancer resolution 

    Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
    @gyuho
    gyuho committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    ba42e65 View commit details
    Browse the repository at this point in the history

  11. integration: match code.Canceled in "TestV3KVInflightRangeRequests" 

    Match new error codes in gRPC v1.22.0

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
    @gyuho
    gyuho committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    8a2a951 View commit details
    Browse the repository at this point in the history

  12. words: whitelist more 

    Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
    @gyuho
    gyuho committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    a7b8034 View commit details
    Browse the repository at this point in the history