Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default log level to fatal #10946

Closed
wants to merge 1 commit into from
Closed

default log level to fatal #10946

wants to merge 1 commit into from

Conversation

benitogf
Copy link

I think that the default log level should be fatal, was trying to silence output from an embed server with zap but there's no config for that, however with this change the Debug flag effectively silence output

@gyuho gyuho mentioned this pull request Jul 29, 2019
Merged
@gyuho
Copy link
Contributor

gyuho commented Jul 29, 2019

I sent out a PR to make this configurable in etcd side #10947.

@gyuho gyuho closed this Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benitogf @gyuho