Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/adt: interval tree based on rbtree #10978

Merged
merged 2 commits into from
Aug 5, 2019
Merged

pkg/adt: interval tree based on rbtree #10978

merged 2 commits into from
Aug 5, 2019

Conversation

xkeyideal
Copy link

@gyuho
Copy link
Contributor

gyuho commented Aug 5, 2019

Please make this Fatalf:

t.Logf("level order after deleting '11' expected %v, got %v", expectedAfterDelete11, visitsAfterDelete11)

@xkeyideal
Copy link
Author

@gyuho I didn't change the interval_tree_test.go file

@gyuho
Copy link
Contributor

gyuho commented Aug 5, 2019

@xkeyideal I meant, we should change this to Fatalf with this PR, so we can validate the fix

t.Logf("level order after deleting '11' expected %v, got %v", expectedAfterDelete11, visitsAfterDelete11)

If this fix is correct, it will pass. If not, it will fail.

@xkeyideal
Copy link
Author

@gyuho has changed

@gyuho
Copy link
Contributor

gyuho commented Aug 5, 2019

@xkeyideal Awesome. Thanks for the contribution!

@gyuho gyuho merged commit 7763b6b into etcd-io:master Aug 5, 2019
gyuho pushed a commit that referenced this pull request Aug 5, 2019
Author: xkey <xk33430@ly.com>
ref. #10978

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
Copy link
Contributor

gyuho commented Aug 5, 2019

This fix is merged as 003362e.

Thanks @xkeyideal !

gyuho pushed a commit that referenced this pull request Aug 5, 2019
Author: xkey <xk33430@ly.com>
ref. #10978

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@jingyih
Copy link
Contributor

jingyih commented Aug 5, 2019

@xkeyideal Thanks!

@jingyih
Copy link
Contributor

jingyih commented Aug 5, 2019

@gyuho I think we need to backport this? Also update the changelog? Feel free to assign me.

@gyuho
Copy link
Contributor

gyuho commented Aug 5, 2019

@jingyih Already backported :)

@gyuho
Copy link
Contributor

gyuho commented Aug 5, 2019

I meant, backported to 3.4 branch. Not yet for 3.3. Let's run tests during our 3.4 release cycle. If it looks good, we can backport 003362e to 3.3

gyuho pushed a commit that referenced this pull request Aug 9, 2019
Author: xkey <xk33430@ly.com>
ref. #10978

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
hexfusion pushed a commit to openshift/etcd that referenced this pull request Sep 26, 2019
Author: xkey <xk33430@ly.com>
ref. etcd-io#10978

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants