-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/adt: interval tree based on rbtree #10978
Conversation
Please make this etcd/pkg/adt/interval_tree_test.go Line 301 in 9a2af73
|
@gyuho I didn't change the interval_tree_test.go file |
@xkeyideal I meant, we should change this to etcd/pkg/adt/interval_tree_test.go Line 301 in 9a2af73
If this fix is correct, it will pass. If not, it will fail. |
@gyuho has changed |
@xkeyideal Awesome. Thanks for the contribution! |
Author: xkey <xk33430@ly.com> ref. #10978 Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
This fix is merged as 003362e. Thanks @xkeyideal ! |
Author: xkey <xk33430@ly.com> ref. #10978 Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@xkeyideal Thanks! |
@gyuho I think we need to backport this? Also update the changelog? Feel free to assign me. |
@jingyih Already backported :) |
I meant, backported to 3.4 branch. Not yet for 3.3. Let's run tests during our 3.4 release cycle. If it looks good, we can backport 003362e to 3.3 |
Author: xkey <xk33430@ly.com> ref. #10978 Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Author: xkey <xk33430@ly.com> ref. etcd-io#10978 Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Please read https://github.com/etcd-io/etcd/blob/master/CONTRIBUTING.md#contribution-flow.