-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cherry pick "etcd_cluster_version" metric" (#10257, #11233, #11254, #11265) to release-3.3 #11261
cherry pick "etcd_cluster_version" metric" (#10257, #11233, #11254, #11265) to release-3.3 #11261
Conversation
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
a4793be
to
3fc4cc3
Compare
/cc @jingyih hmm, failed test said
But I brought up an etcd node and checked the metrics it is as expected: |
I can take a look. This test is skipped in current master branch. Might be an actual bug we did not catch in the master before backporting. |
Oh I misread. This is a test fail on a backported test. No wonder I cannot reproduce locally... |
3fc4cc3
to
e788880
Compare
Please also cherry pick #11265 to fix the test failure. |
@jingyih yes, the third commit already includes #11265, failure mentioned earlier is fixed:
but travis still failed: |
lgtm, thanks @jingyih @wenjiaswe |
Add log for etcd_cluster_version metrics addition in #11261
Add log for etcd_cluster_version metrics addition in #11261
Add log for etcd_cluster_version metrics addition in etcd-io#11261
Cherry pick of #10257 on release-3.3.
#10257: etcdserver/*: add "etcd_cluster_version" metric