-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lease: fix memory leak in LeaseGrant #11731
Conversation
leader can call leaseExpiredNotifier.Unregister() to pop item when lessor is revoked, but follower node has no way to pop it. it is not necessary to register it into the queue when lessor is not primary. if leader change, promote method can rebuild it in new leader and demote method can clear leaseExpiredNotifier in old leader. |
Codecov Report
@@ Coverage Diff @@
## master #11731 +/- ##
==========================================
- Coverage 66.58% 66.19% -0.39%
==========================================
Files 403 403
Lines 36763 36787 +24
==========================================
- Hits 24477 24351 -126
- Misses 10779 10942 +163
+ Partials 1507 1494 -13
Continue to review full report at Codecov.
|
855d492
to
b1da829
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great find. thanks for the fix
The fix is included in v3.4.6 (2020-03-29). |
fix issue #11730 #11495