[Etcd downgrade] Apply downgrade policy to server #11919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoyinZyc
force-pushed
the
downgrade-policy
branch
from
31e1add to
941adfc
Compare
Codecov Report
@@ Coverage Diff @@
## master #11919 +/- ##
==========================================
+ Coverage 65.40% 65.89% +0.48%
==========================================
Files 403 404 +1
Lines 37250 37290 +40
==========================================
+ Hits 24365 24572 +207
+ Misses 11356 11203 -153
+ Partials 1529 1515 -14
Continue to review full report at Codecov.
|
gyuho
reviewed
Jun 2, 2020
gyuho
reviewed
Jun 2, 2020
YoyinZyc
force-pushed
the
downgrade-policy
branch
2 times, most recently
from
13f6b80 to
3cadaf7
Compare
|
@gyuho Friendly ping. Can you have another look? |
|
Will take a look today. Thanks! |
gyuho
reviewed
Jun 24, 2020
etcdserver/api/capability.go
Outdated
| @@ -15,6 +15,7 @@ | |||
| package api | |||
|
|
|||
| import ( | |||
| "go.etcd.io/etcd/v3/etcdserver/api/membership" | |||
There was a problem hiding this comment.
Can we sort import lines? Place it below "go.etcd.io/etcd/v3/version"?
gyuho
approved these changes
Jun 24, 2020
YoyinZyc
force-pushed
the
downgrade-policy
branch
from
3cadaf7 to
2541b0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4th step of #11716.
The PR adjusted downgrade version latch to server. Previously, cluster will not allow lower version member to join in. With downgrade, the cluster can open such latch if downgrade is enabled.
Based on the discussion here, the cluster only allows member with downgrade target version to join in during downgrading.