Automated cherry pick of #11946 #11977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to run an etcd node for testing and development without placing lots of load on the file system. Fixes etcd-io#11930. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
jpbetz
force-pushed
the
automated-cherry-pick-of-#11946-release-3.4
branch
from
2d89bec
to
78f6798
Compare
gyuho
approved these changes
Jun 5, 2020
|
w00t! thanks @jpbetz |
dims
reviewed
Jun 5, 2020
| @@ -258,6 +258,7 @@ func newConfig() *config { | |||
| fs.IntVar(&cfg.ec.ExperimentalCompactionBatchLimit, "experimental-compaction-batch-limit", cfg.ec.ExperimentalCompactionBatchLimit, "Sets the maximum revisions deleted in each compaction batch.") | |||
|
|
|||
| // unsafe | |||
| fs.BoolVar(&cfg.ec.UnsafeNoFsync, "unsafe-no-fsync", false, "Disables fsync, unsafe, will cause data loss.") | |||
There was a problem hiding this comment.
Can we please mark it as hidden flag?
There was a problem hiding this comment.
Looks like it already is, although I'm not sure that is what we had intended for master:
Lines 26 to 31 in 49f91d6
... no unsafe-no-fsync section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #11946 on release-3.4.
#11946: etcdserver, et al: add --unsafe-no-fsync flag
While the policy is usually to NOT backport features to stable branches, I think we should consider making an exception for this given that (a) it is intended to be used in test and (b) it has a lot of promise to speed up tests significantly. If this makes a noticeable dent in k8s test times, and I think it might, it could really help the project.
cc @gyuho @jingyih @dims