Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth: Customize the settings of simpleTokenTTL. #11980

Merged
merged 1 commit into from
Jun 22, 2020
Merged

auth: Customize the settings of simpleTokenTTL. #11980

merged 1 commit into from
Jun 22, 2020

Conversation

cfc4n
Copy link
Contributor

@cfc4n cfc4n commented Jun 6, 2020

auth: Customize simpleTokenTTL settings.

simple Token TTL default value is auth.simpleTokenTTL = 5 * time.Minute.

Sometimes, this value is not sufficient for use, I hope it can be given to the user to customize the setting.

Fixes #11978

This was referenced Jun 6, 2020
Closed
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2020 •
edited
Loading

Codecov Report

Merging #11980 into master will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11980      +/-   ##
==========================================
- Coverage   65.96%   65.81%   -0.15%     
==========================================
  Files         403      403              
  Lines       37306    37327      +21     
==========================================
- Hits        24608    24566      -42     
- Misses      11182    11224      +42     
- Partials     1516     1537      +21
Impacted Files Coverage Δ
etcdserver/config.go 79.51% <ø> (ø)
etcdserver/server.go 75.43% <ø> (-0.46%) ⬇️
auth/simple_token.go 77.23% <100.00%> (-11.84%) ⬇️
auth/store.go 71.62% <100.00%> (+18.67%) ⬆️
embed/config.go 54.26% <100.00%> (+0.13%) ⬆️
embed/etcd.go 74.54% <100.00%> (+0.05%) ⬆️
etcdmain/config.go 84.14% <100.00%> (+0.07%) ⬆️
clientv3/balancer/utils.go 53.84% <0.00%> (-46.16%) ⬇️
client/client.go 42.81% <0.00%> (-30.72%) ⬇️
pkg/transport/timeout_conn.go 60.00% <0.00%> (-20.00%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f91d6...d507ab4. Read the comment docs.

@cfc4n cfc4n changed the title auth: Customize simpleTokenTTL settings. auth: Customize the settings of simpleTokenTTL. Jun 7, 2020
@xiang90
Copy link
Contributor

xiang90 commented Jun 10, 2020

What is your use case to shorten this?

@cfc4n
Copy link
Contributor Author

cfc4n commented Jun 10, 2020

What is your use case to shorten this?

Please read #11978 (comment) for the reason.

spzala
spzala reviewed Jun 10, 2020
View reviewed changes
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cfc4n meanwhile you wait for reviews, can you please fix this small build error https://travis-ci.com/github/etcd-io/etcd/jobs/344653990#L356 thanks!

@xiang90
Copy link
Contributor

xiang90 commented Jun 10, 2020

can you also add this change to changelog and reflect in the documentation of the flags?

@cfc4n
Copy link
Contributor Author

cfc4n commented Jun 11, 2020 •
edited
Loading

@cfc4n meanwhile you wait for reviews, can you please fix this small build error https://travis-ci.com/github/etcd-io/etcd/jobs/344653990#L356 thanks!

OK,I'll finish it today .

@cfc4n
Copy link
Contributor Author

cfc4n commented Jun 11, 2020

can you also add this change to changelog and reflect in the documentation of the flags?

Do I need to send a new PR for CHANGELOG or in this pr?

@cfc4n cfc4n mentioned this pull request Jun 11, 2020
Merged
mitake
mitake approved these changes Jun 14, 2020
View reviewed changes
Copy link
Contributor

@mitake mitake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cfc4n cfc4n requested a review from spzala June 15, 2020 06:52
@cfc4n
Copy link
Contributor Author

cfc4n commented Jun 16, 2020 •
edited
Loading

@spzala @gyuho PTAL, Thanks.

gyuho added a commit that referenced this pull request Jun 22, 2020
@gyuho
Merge pull request #12001 from cfc4n/master
6ec5d5f 
CHANGELOG: update for PR #11980 ,  #11986 ,  # 11987 ,
@gyuho gyuho merged commit ebdcced into etcd-io:master Jun 22, 2020
@cfc4n cfc4n deleted the simple-token-ttl branch June 22, 2020 11:00
This was referenced Jun 25, 2020
Merged
Merged
gyuho added a commit that referenced this pull request Jun 26, 2020
@gyuho
Merge pull request #12078 from cfc4n/automated-cherry-pick-of-#11980-…
c88a2c8 
…upstream-release-3.3

Automated cherry pick of #11980
gyuho added a commit that referenced this pull request Jun 26, 2020
@gyuho
Merge pull request #12077 from cfc4n/automated-cherry-pick-of-#11980-…
d5dec73 
…upstream-release-3.4

Automated cherry pick of #11980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitake mitake mitake approved these changes

@spzala spzala Awaiting requested review from spzala

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auth: Customize simpleTokenTTL settings
6 participants
@cfc4n @codecov-commenter @xiang90 @mitake @spzala @gyuho