Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdserver: Avoid panics logging slow v2 requests in integration tests #12238

Merged
merged 1 commit into from
Aug 19, 2020
Merged

etcdserver: Avoid panics logging slow v2 requests in integration tests #12238

merged 1 commit into from
Aug 19, 2020

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Aug 19, 2020

Addresses #12197 in master

Should be picked to 3.4 to make the etcd server usable for integration tests downstream

cc @jingyih @gyuho

@liggitt liggitt mentioned this pull request Aug 19, 2020
Merged
@liggitt
Copy link
Contributor Author

liggitt commented Aug 19, 2020

Cherry-pick to release-3.4 open in #12239

This was referenced Aug 19, 2020
Closed
Closed
@jingyih
Copy link
Contributor

jingyih commented Aug 19, 2020

lgtm. Could you update the commit title to etcdserver: Avoid panics logging slow v2 requests in integration tests. The CI tests in etcd repo enforce the commit title to have a format of package: description.

@liggitt
Copy link
Contributor Author

liggitt commented Aug 19, 2020

done

@liggitt liggitt changed the title Avoid panics logging slow v2 requests in integration tests etcdserver: Avoid panics logging slow v2 requests in integration tests Aug 19, 2020
jingyih
jingyih reviewed Aug 19, 2020
View reviewed changes
Copy link
Contributor

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. defer to @gyuho

gyuho
gyuho approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thx!

@gyuho gyuho merged commit 44dea5d into etcd-io:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingyih jingyih jingyih left review comments

@gyuho gyuho gyuho approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liggitt @jingyih @gyuho