Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: fix log info error #12314

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Conversation

viviyww
Copy link
Contributor

@viviyww viviyww commented Sep 18, 2020

etcdserver#util.go#warnOfExpensiveReadOnlyTxnRequest logs with wrong prefix "read-only range ".
It has to be "read-only txn ".

Fixes #12295

@viviyww viviyww changed the title Fix log info error etcdserver: change warnOfExpensiveReadOnlyTxnRequest log prefix Sep 18, 2020
@viviyww
Copy link
Contributor Author

viviyww commented Sep 18, 2020

/assign @spzala

@viviyww
Copy link
Contributor Author

viviyww commented Sep 18, 2020

/assign @jingyih

@jingyih
Copy link
Contributor

jingyih commented Sep 18, 2020

Could you change your commit title to etcdserver: fix log info error?

@viviyww
Copy link
Contributor Author

viviyww commented Sep 21, 2020

Could you change your commit title to etcdserver: fix log info error?

Ok, thanks.

@viviyww viviyww changed the title etcdserver: change warnOfExpensiveReadOnlyTxnRequest log prefix etcdserver: fix log info error Sep 21, 2020
etcdserver#util.go#warnOfExpensiveReadOnlyTxnRequest logs with wrong prefix "read-only range ".
It has to be "read-only txn ".

fixes etcd-io#12295
Copy link
Contributor

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jingyih
Copy link
Contributor

jingyih commented Sep 21, 2020

Test failure unrelated to this PR.

@jingyih jingyih merged commit 353fcf0 into etcd-io:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Logging
2 participants