Automated cherry pick of #12165 #12365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitake
approved these changes
Nov 22, 2020
There was a problem hiding this comment.
LGTM, thanks! Travis was failed because of TARGET=linux-amd64-integration-4-cpu but TARGET=linux-amd64-integration-1-cpu was passed. The failed case is TestBalancerUnderNetworkPartitionWatchLeader and it isn't related to this PR. I'd like to take a look when I can have a time for this.
Defer to @jingyih
cfc4n
deleted the
automated-cherry-pick-of-#12165-upstream-release-3.3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #12165 on release-3.3.
#12165: etcdserver: check authinfo if it is not