-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yxjetcd pprof UI #12415
Yxjetcd pprof UI #12415
Conversation
# Conflicts: # go.mod # go.sum # pkg/go.mod # tests/go.sum
# Conflicts: # go.mod # go.sum # pkg/go.mod # tests/go.sum
--@tobilarscheid-- @tbg @yangxuanjia |
Pretty sure I am tagged by mistake :-) |
I'm sorry about this. I should have tagged @tbg because of these commits: cockroachdb/cockroach@9d7ca0f |
@ptabor |
@yangxuanjia I'm not questioning whether its useful. I just think that etcd community does not want to maintain its own clone of 1kloc maintained in another project. I would propose working with cockrouchdb community for finding a shared location for that code. |
@ptabor you are right, it's better. |
FYI panicparse v2 has this: https://github.com/maruel/panicparse/blob/master/stack/webstack/webstack.go You may want to just use that directly. We wrote our code before this was available. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
Closing this PR, but happy to review integration with library supporting this, e.g. panicparse v2 in a separate PR as Tobis mentioned. |
add pprof UI for etcd
// http://127.0.0.1/debug/pprof/ui/
// http://127.0.0.1/debug/pprof/ui/allocs
// http://127.0.0.1/debug/pprof/ui/profile
// http://127.0.0.1/debug/pprof/ui/heap
// http://127.0.0.1/debug/pprof/goroutineui/
// http://127.0.0.1/debug/pprof/ui/block
// http://127.0.0.1/debug/pprof/ui/goroutine
// http://127.0.0.1/debug/pprof/ui/mutex
// http://127.0.0.1/debug/pprof/ui/threadcreate