backend: set seq flag for each bucket buffer #12568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptabor
approved these changes
Jan 31, 2021
| @@ -37,11 +37,12 @@ func (txb *txBuffer) reset() { | |||
| // txWriteBuffer buffers writes of pending updates that have not yet committed. | |||
| type txWriteBuffer struct { | |||
| txBuffer | |||
| seq bool | |||
| seq map[string]bool | |||
There was a problem hiding this comment.
Please comment about semantic of this field (what's the key and what the value represents).
|
./scripts/fix.sh should fix the formatting problem (superfluous empty line). |
ptabor
added a commit
that referenced
this pull request
May 14, 2021
ptabor
added a commit
that referenced
this pull request
May 14, 2021
|
I applied my suggestions on top of the PR - so from my perspective its good for merge. @wilsonwang371 - could you, please, take a look as its related to code you are actively working on. |
|
The branch tests a green: The PR was pushed before the reorg - so the tests results are not shown on the PR-level |
|
Btw, shall we change the variable name to make it more clear with the new changes? |
|
Migrated to: #12986 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves two problems:
seqflag totruewhen resetting the wholetxWriteBuffer, otherwise thewritebackmethod always sort the buffer onceseqset tofalseseqflag to reduce sort times, as most of the data is stored in thekeybucket, which grows in sequence.