Cleanup grpc client/v3/naming API #12675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptabor
force-pushed
the
20210209-grpc-remove-legacy-resolver
branch
from
5ca5a44
to
7938563
Compare
gyuho
reviewed
Feb 9, 2021
server/proxy/grpcproxy/cluster.go
Outdated
| @@ -79,38 +82,36 @@ func NewClusterProxy(lg *zap.Logger, c *clientv3.Client, advaddr string, prefix | |||
| return cp, donec | |||
| } | |||
|
|
|||
| func (cp *clusterProxy) resolve(prefix string) { | |||
| func (cp *clusterProxy) establishEndpointWatch(em endpoints.Manager, prefix string) { | |||
There was a problem hiding this comment.
So, establishEndpointWatch is a method and we create em endpoints.Manager only once, right? Think em endpoints.Manager is better defined as a field inside cp *clusterProxy?
ptabor
force-pushed
the
20210209-grpc-remove-legacy-resolver
branch
from
7938563
to
858bafe
Compare
Update grpcproxy to use the new abstractions.
ptabor
force-pushed
the
20210209-grpc-remove-legacy-resolver
branch
from
858bafe
to
a836a80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
It's part of #12652 effort.