Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests: Use testing.T logger through zap for grpc #12781

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

ptabor
Copy link
Contributor

@ptabor ptabor commented Mar 16, 2021

This finishes of unification of testing infrastructure for integration tests.

Now: RAFT + GRPC + per-etcd-member data are logged in consistent way through testing.T.

In case of test failure, the printed log contains all and only relevant information. It's very useful to understand root-causes of flakes.

@ptabor ptabor force-pushed the 20210315-flaki-balancer branch 2 times, most recently from f62c5f5 to a63708d Compare March 16, 2021 15:14
@ptabor ptabor force-pushed the 20210315-flaki-balancer branch from a63708d to ee3182e Compare March 16, 2021 22:08
@codecov-io
Copy link

Codecov Report

Merging #12781 (ee3182e) into master (e599f4a) will decrease coverage by 6.26%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12781      +/-   ##
==========================================
- Coverage   72.24%   65.97%   -6.27%     
==========================================
  Files         427      410      -17     
  Lines       33159    32692     -467     
==========================================
- Hits        23955    21568    -2387     
- Misses       7271     9205    +1934     
+ Partials     1933     1919      -14     
Flag Coverage Δ
all 65.97% <40.00%> (-6.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/embed/config_logging.go 62.40% <25.00%> (+6.68%) ⬆️
server/etcdserver/raft.go 85.38% <100.00%> (ø)
raft/quorum/quorum.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/tlsutil/cipher_suites.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/transport/sockopt_unix.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/report/report.go 0.00% <0.00%> (-95.58%) ⬇️
pkg/srv/srv.go 0.00% <0.00%> (-87.94%) ⬇️
pkg/report/timeseries.go 0.00% <0.00%> (-86.77%) ⬇️
pkg/expect/expect.go 0.00% <0.00%> (-84.29%) ⬇️
pkg/osutil/interrupt_unix.go 0.00% <0.00%> (-82.61%) ⬇️
... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e599f4a...ee3182e. Read the comment docs.

@ptabor ptabor force-pushed the 20210315-flaki-balancer branch from ee3182e to 725a8c5 Compare March 17, 2021 07:17
@ptabor ptabor merged commit 2932969 into etcd-io:master Mar 18, 2021
@ptabor ptabor deleted the 20210315-flaki-balancer branch March 18, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants