[release-3.4]: Pin go version in go.mod to 1.12 #12839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As go 1.12.2 is what is tested in CI as well as recommended to be built with 1.12.2 we should also pin to this in the go directive version.
|
I tried to follow the contributing guide around the commit msgs, let me know if there is anything incorrect, happy to make the needed changes! |
|
Not sure I understand the e2e test failures, any hints at what I could look at? 🤔 |
|
3.4 are pretty flaky. A lot of improvement in 3.5 tests. Adding Line 120 in 82eae92 will at least eliminated one of the 'flakes. |
Nice to hear that! 🎉 Thanks for the suggestion! Do you want me to include that in this PR? |
|
Yes - let's try to add this commit -> and this will retrigger the tests. Maybe we will get lucky. |
|
Thank you for the fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As go 1.12 is what is tested in CI as well as recommended to be built
with 1.12 we should also pin to this in the go directive version of go.mod file.
Fixes #12838.