Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.5] server: set multiple concurrentReadTx instances share one txReadBuffer. #13036

Merged
merged 1 commit into from
May 25, 2021

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented May 24, 2021

@gyuho gyuho added the WIP label May 24, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #13036 (7a7d6f9) into release-3.5 (c0d1450) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.5   #13036      +/-   ##
===============================================
+ Coverage        62.70%   62.92%   +0.21%     
===============================================
  Files              432      421      -11     
  Lines            33354    33598     +244     
===============================================
+ Hits             20915    21141     +226     
+ Misses           10359    10354       -5     
- Partials          2080     2103      +23     
Flag Coverage Δ
all 62.92% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/mvcc/backend/backend.go 79.85% <100.00%> (+2.21%) ⬆️
server/mvcc/backend/tx_buffer.go 89.74% <100.00%> (+0.26%) ⬆️
raft/quorum/quorum.go 0.00% <0.00%> (-100.00%) ⬇️
raft/tracker/state.go 0.00% <0.00%> (-100.00%) ⬇️
raft/util.go 20.56% <0.00%> (-65.43%) ⬇️
raft/confchange/restore.go 39.53% <0.00%> (-55.82%) ⬇️
raft/raftpb/confchange.go 22.97% <0.00%> (-52.71%) ⬇️
raft/quorum/voteresult_string.go 0.00% <0.00%> (-50.00%) ⬇️
raft/quorum/majority.go 60.75% <0.00%> (-39.25%) ⬇️
etcdctl/ctlv3/command/watch_command.go 5.29% <0.00%> (-37.65%) ⬇️
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0d1450...7a7d6f9. Read the comment docs.

@gyuho gyuho merged commit dd22bd7 into etcd-io:release-3.5 May 25, 2021
@gyuho gyuho deleted the cherry-pick branch May 25, 2021 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants