-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
embed: unlimit the recv msg size of grpc-gateway #13077
Conversation
Ensure the client which access etcd via grpc-gateway won't be limited by the MaxCallRecvMsgSize. Here we choose the same default value of etcdcli as grpc-gateway's MaxCallRecvMsgSize. Fix etcd-io#12576
I am not familiar with etcd's test so I don't know how to test it in the CI. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #13077 +/- ##
==========================================
- Coverage 67.90% 61.49% -6.41%
==========================================
Files 437 418 -19
Lines 33831 33009 -822
==========================================
- Hits 22973 20299 -2674
- Misses 8895 10637 +1742
- Partials 1963 2073 +110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Very useful PR, looking forward to being merged soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
The etcd gRPC Server MaxSendMsgSize is also math.MaxInt32. @gyuho PTAL.
@spacewander @tangcong Sorry for the delay. Can we also backport to 3.5? |
@tangcong There are still many users using the version 3.3,could you also backport it to 3.3? |
Ensure the client which access etcd via grpc-gateway won't
be limited by the MaxCallRecvMsgSize. Here we choose the same
default value of etcdcli as grpc-gateway's MaxCallRecvMsgSize.
Fix #12576