[backport 3.4]: server/auth: enable tokenProvider if recoved store enables auth #13206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the CI fail shouldn't be related to the change, lgtm, thanks @cfz |
mitake
approved these changes
Jul 13, 2021
|
@hexfusion could you check it's ok to merge this PR to the stable branch? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
|
etcd 3.4 and 3.5 have not yet fixed the lease leak issue and It will cause etcd to accumulate millions of keys over time until the db is full. We should reopen and merge this pr. thanks. @mitake @spzala @serathius |
|
@cfz Could you please rebase this PR? Sorry for the delay of reviewing this PR. |
…ables auth this is a manual backport of etcd-io#13172
cfz
force-pushed
the
cherry-pick-#13172-r34
branch
from
e1528c2
to
23e79db
Compare
|
@ahrtr done, PTAL |
ahrtr
approved these changes
May 6, 2022
|
Sorry for missing this PR, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a manual backport of #13172
we would also like to have this fix in release 3.4
cc @mitake @spzala