tests: Add SIGKILL functional test #13924
Conversation
Codecov Report
@@ Coverage Diff @@
## main #13924 +/- ##
==========================================
+ Coverage 72.41% 72.48% +0.07%
==========================================
Files 469 469
Lines 38411 38411
==========================================
+ Hits 27814 27841 +27
+ Misses 8798 8783 -15
+ Partials 1799 1787 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -185,6 +185,8 @@ tester-config: | |||
| - SIGTERM_ALL | |||
| - SIGQUIT_AND_REMOVE_ONE_FOLLOWER | |||
| - SIGQUIT_AND_REMOVE_ONE_FOLLOWER_UNTIL_TRIGGER_SNAPSHOT | |||
| - SIGKILL_FOLLOWER | |||
There was a problem hiding this comment.
SIGKILL_ONE_FOLLOWER so as to keep the naming consistent as the existing SIGTERM_ONE_FOLLOWER and SIGQUIT_AND_REMOVE_ONE_FOLLOWER ?
| @@ -426,6 +429,8 @@ enum Case { | |||
| // each member must be able to process client requests. | |||
| SIGQUIT_AND_REMOVE_QUORUM_AND_RESTORE_LEADER_SNAPSHOT_FROM_SCRATCH = 14; | |||
|
|
|||
| SIGKILL_FOLLOWER = 15; | |||
There was a problem hiding this comment.
SIGKILL_ONE_FOLLOWER? The same as above.
|
Basically looks good to me with one minor comment. Another comment is there are some duplicate code, such as handler.go#L555-L565. We may get them wrapped into a common function or method. But of course we can address it in a separate PR. I can also do it once this one is merged. |
| @@ -174,6 +174,30 @@ func recover_SIGQUIT_ETCD_AND_REMOVE_DATA(clus *Cluster, idx1 int) error { | |||
| return err | |||
| } | |||
|
|
|||
| func inject_SIGKILL(clus *Cluster, index int) error { | |||
| clus.lg.Info( | |||
| "disastrous machine failure START", | |||
| ) | ||
| err := clus.sendOp(index, rpcpb.Operation_SIGKILL_ETCD) | ||
| clus.lg.Info( | ||
| "disastrous machine failure END", |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
Splitting #13838 into mergable code
cc @ptabor @ahrtr