Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix corruption checks v3.5 #14282

Merged
merged 29 commits into from
Sep 7, 2022
Merged

Fix corruption checks v3.5 #14282

merged 29 commits into from
Sep 7, 2022

Commits on Sep 7, 2022

  1. server: Extract triggerCorruptAlarm to function 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    d32de2c View commit details
    Browse the repository at this point in the history

  2. server: Extract corruption detection to dedicated struct 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    35cbdf3 View commit details
    Browse the repository at this point in the history

  3. server: Cover corruptionMonitor with tests 

    Get 100% coverage on InitialCheck and PeriodicCheck functions to avoid
any mistakes.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    78a6f38 View commit details
    Browse the repository at this point in the history

  4. server: Test HashByRev values to make sure they don't change 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    336fef4 View commit details
    Browse the repository at this point in the history

  5. server: Extract unsafeHashByRev function 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    bc592c7 View commit details
    Browse the repository at this point in the history

  6. server: Move unsafeHashByRev to new hash.go file 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    3f26995 View commit details
    Browse the repository at this point in the history

  7. server: Extract kvHash struct 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    f5ed371 View commit details
    Browse the repository at this point in the history

  8. server: Refactor hasher 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    679e327 View commit details
    Browse the repository at this point in the history

  9. server: Return error from scheduleCompaction 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    22d3e4e View commit details
    Browse the repository at this point in the history

  10. server: Move reading KV index inside scheduleCompaction function 

    Makes it easier to test hash match between scheduleCompaction and
HashByRev.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    ea684db View commit details
    Browse the repository at this point in the history

  11. server: Fix range in mock not returning same number of keys and values 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    f1a759a View commit details
    Browse the repository at this point in the history

  12. server: Calculate hash during compaction 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    21e5d5d View commit details
    Browse the repository at this point in the history

  13. server: Pass revision as int 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    2b8dd0d View commit details
    Browse the repository at this point in the history

  14. server: Move adjusting revision to hasher 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    991b429 View commit details
    Browse the repository at this point in the history

  15. server: Store real rv range in hasher 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    1ff5992 View commit details
    Browse the repository at this point in the history

  16. server: Return revision range that hash was calcualted for 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    a3f609d View commit details
    Browse the repository at this point in the history

  17. server: Remove duplicated compaction revision 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    6311072 View commit details
    Browse the repository at this point in the history

  18. server: Extract hasher to separate interface 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    7358362 View commit details
    Browse the repository at this point in the history

  19. server: Cache compaction hash for HashByRev API 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    1200b10 View commit details
    Browse the repository at this point in the history

  20. tests: Add integration tests for compact hash 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    d3db3bc View commit details
    Browse the repository at this point in the history

  21. tests: Add tests for HashByRev HTTP API 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    00bc8da View commit details
    Browse the repository at this point in the history

  22. tests: Unify TestCompactionHash and extend it to also Delete keys and… 

    … Defrag

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    037a898 View commit details
    Browse the repository at this point in the history

  23. tests: Rename corruptHash to CorruptBBolt 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    a8020a0 View commit details
    Browse the repository at this point in the history

  24. tests: Move CorruptBBolt to testutil 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    8d4ca10 View commit details
    Browse the repository at this point in the history

  25. server: Refactor compaction checker 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    4a75e3d View commit details
    Browse the repository at this point in the history

  26. tests: Cover periodic check in tests 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    a56ec0b View commit details
    Browse the repository at this point in the history

  27. server: Implement compaction hash checking 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    21fb173 View commit details
    Browse the repository at this point in the history

  28. server: Make corrtuption check optional and period configurable 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    5660bf0 View commit details
    Browse the repository at this point in the history

  29. tests: Fix member id in CORRUPT alarm 

    Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
    @serathius
    serathius committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    2ddb9e0 View commit details
    Browse the repository at this point in the history