etcdctl: fix move-leader for multiple endpoints #14445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjungblu
commented
Sep 9, 2022
| @@ -88,13 +101,12 @@ func testCtlV3MoveLeader(t *testing.T, cfg e2e.EtcdProcessClusterConfig) { | |||
| } | |||
| } | |||
|
|
|||
| os.Setenv("ETCDCTL_API", "3") | |||
| defer os.Unsetenv("ETCDCTL_API") | |||
There was a problem hiding this comment.
this was spouting a warning, so I thought I'd clean this up. Let me know if I should leave it.
There was a problem hiding this comment.
ETCDCTL_API is 3 by default, why the case need this? It should be legacy "issue". So it's Ok to remove it.
Due to a duplicate call of clientConfigFromCmd, the move-leader command would fail with "conflicting environment variable is shadowed by corresponding command-line flag". Also in scenarios where no command-line flag was supplied. Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
tjungblu
force-pushed
the
movelead_main
branch
from
2eb3653
to
3fc1660
Compare
|
FYI. #14443 I realized that the |
ahrtr
approved these changes
Sep 9, 2022
serathius
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a duplicate call of clientConfigFromCmd, the move-leader command would fail with "conflicting environment variable is shadowed by corresponding command-line flag". Also in scenarios where no command-line flag was supplied.
Signed-off-by: Thomas Jungblut tjungblu@redhat.com
main pick of #14434 and #14441
thanks @ahrtr for triple checking me :)