Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] server: refresh auth info when etcd recovers from a snapshot #14649

Merged
merged 2 commits into from
Oct 29, 2022

Conversation

mitake
Copy link
Contributor

@mitake mitake commented Oct 29, 2022

…PermCache

Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
@ahrtr
Copy link
Member

ahrtr commented Oct 29, 2022

I suggest to backport #14574 to 3.4 in this PR as well. FYI #14648 (comment)

Signed-off-by: Oleg Guba <oleg@dropbox.com>
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
@mitake
Copy link
Contributor Author

mitake commented Oct 29, 2022

@veshij Can I backport your fix to this PR? We have a unit test to verify the behavior so can work on e2e test later.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @mitake

@ahrtr ahrtr merged commit 7c1499d into etcd-io:release-3.4 Oct 29, 2022
@ahrtr ahrtr changed the title [3.4] server: add a unit test case for authStore.Reocver() with empty rangePermCache [3.4] server: refresh auth info when etcd recovers from a snapshot Oct 29, 2022
@ahrtr
Copy link
Member

ahrtr commented Oct 29, 2022

Also partially backport #14574

@ahrtr ahrtr mentioned this pull request Oct 29, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants