Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added e2e test case for issue 14571: etcd doesn't load auth info when recovering from a snapshot #14656

Merged
merged 1 commit into from
Oct 30, 2022

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Oct 30, 2022

Signed-off-by: Benjamin Wang wachao@vmware.com

cc @mitake @biosvs @veshij

@ahrtr
Copy link
Member Author

ahrtr commented Oct 30, 2022

Added e2e test case for 3.5 for #14571

…o when recovering from a snapshot

Signed-off-by: Benjamin Wang <wachao@vmware.com>
@mitake
Copy link
Contributor

mitake commented Oct 30, 2022

@ahrtr LGTM, thanks a lot for creating the e2e test case! I tested that not refreshing range perm cache can result in failure of the test on my env. I think it's also valuable to add the test case to the main branch?

@mitake mitake merged commit 0a0f0e3 into etcd-io:release-3.5 Oct 30, 2022
@ahrtr
Copy link
Member Author

ahrtr commented Oct 30, 2022

@ahrtr LGTM, thanks a lot for creating the e2e test case! I tested that not refreshing range perm cache can result in failure of the test on my env. I think it's also valuable to add the test case to the main branch?

@veshij already added e2e test on main branch in #14574. release-3.5 has huge difference from main branch, and there is no easy way to backport the e2e test to release-3.5. So I have to add a new e2e test for 3.5.

@mitake
Copy link
Contributor

mitake commented Oct 30, 2022

Sorry I compared the e2e tests and checked that they are essentially testing the exact same scenario, I misunderstood about how to trigger the condition of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants