raft: delete unused Ready.containsUpdates method #14722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #14722 +/- ##
=======================================
Coverage 75.58% 75.58%
=======================================
Files 457 457
Lines 37323 37323
=======================================
Hits 28211 28211
Misses 7342 7342
Partials 1770 1770
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Always good to see code cleanup. Thank you @nvanbenschoten |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function was unused beyond its own unit test. Delete it.
Signed-off-by: Nathan VanBenschoten nvanbenschoten@gmail.com
Extracted from #14627. cc. @tbg
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.