Linearizability raft before leader send #14752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Please resolve the pipeline failures. |
serathius
force-pushed
the
linearizability-raftBeforeLeaderSend
branch
3 times, most recently
from
194a010
to
20e19df
Compare
|
@ahrtr done |
ahrtr
reviewed
Nov 15, 2022
serathius
force-pushed
the
linearizability-raftBeforeLeaderSend
branch
from
20e19df
to
22ee2e6
Compare
Codecov Report
@@ Coverage Diff @@
## main #14752 +/- ##
==========================================
+ Coverage 75.45% 75.52% +0.06%
==========================================
Files 457 457
Lines 37372 37372
==========================================
+ Hits 28200 28225 +25
+ Misses 7401 7368 -33
- Partials 1771 1779 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
serathius
force-pushed
the
linearizability-raftBeforeLeaderSend
branch
from
22ee2e6
to
f002c49
Compare
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
serathius
force-pushed
the
linearizability-raftBeforeLeaderSend
branch
from
f002c49
to
371179e
Compare
ahrtr
reviewed
Nov 18, 2022
Comment on lines
+36
to
+54
| DefragBeforeCopyPanic Failpoint = goFailpoint{"backend/defragBeforeCopy", "panic", triggerDefrag, AnyMember} | ||
| DefragBeforeRenamePanic Failpoint = goFailpoint{"backend/defragBeforeRename", "panic", triggerDefrag, AnyMember} | ||
| BeforeCommitPanic Failpoint = goFailpoint{"backend/beforeCommit", "panic", nil, AnyMember} | ||
| AfterCommitPanic Failpoint = goFailpoint{"backend/afterCommit", "panic", nil, AnyMember} | ||
| RaftBeforeSavePanic Failpoint = goFailpoint{"etcdserver/raftBeforeSave", "panic", nil, AnyMember} | ||
| RaftAfterSavePanic Failpoint = goFailpoint{"etcdserver/raftAfterSave", "panic", nil, AnyMember} | ||
| BackendBeforePreCommitHookPanic Failpoint = goFailpoint{"backend/commitBeforePreCommitHook", "panic", nil, AnyMember} | ||
| BackendAfterPreCommitHookPanic Failpoint = goFailpoint{"backend/commitAfterPreCommitHook", "panic", nil, AnyMember} | ||
| BackendBeforeStartDBTxnPanic Failpoint = goFailpoint{"backend/beforeStartDBTxn", "panic", nil, AnyMember} | ||
| BackendAfterStartDBTxnPanic Failpoint = goFailpoint{"backend/afterStartDBTxn", "panic", nil, AnyMember} | ||
| BackendBeforeWritebackBufPanic Failpoint = goFailpoint{"backend/beforeWritebackBuf", "panic", nil, AnyMember} | ||
| BackendAfterWritebackBufPanic Failpoint = goFailpoint{"backend/afterWritebackBuf", "panic", nil, AnyMember} | ||
| CompactBeforeCommitScheduledCompactPanic Failpoint = goFailpoint{"mvcc/compactBeforeCommitScheduledCompact", "panic", triggerCompact, AnyMember} | ||
| CompactAfterCommitScheduledCompactPanic Failpoint = goFailpoint{"mvcc/compactAfterCommitScheduledCompact", "panic", triggerCompact, AnyMember} | ||
| CompactBeforeSetFinishedCompactPanic Failpoint = goFailpoint{"mvcc/compactBeforeSetFinishedCompact", "panic", triggerCompact, AnyMember} | ||
| CompactAfterSetFinishedCompactPanic Failpoint = goFailpoint{"mvcc/compactAfterSetFinishedCompact", "panic", triggerCompact, AnyMember} | ||
| CompactBeforeCommitBatchPanic Failpoint = goFailpoint{"mvcc/compactBeforeCommitBatch", "panic", triggerCompact, AnyMember} | ||
| CompactAfterCommitBatchPanic Failpoint = goFailpoint{"mvcc/compactAfterCommitBatch", "panic", triggerCompact, AnyMember} | ||
| RaftBeforeLeaderSendPanic Failpoint = goFailpoint{"etcdserver/raftBeforeLeaderSend", "panic", nil, Leader} |
There was a problem hiding this comment.
There are too many duplicated parameters, e.g. nil, AnyMember. We should only provide a value when it isn't nil or AnyMember. Let's consider to refactor it later in separate PRs.
There was a problem hiding this comment.
Agree, I'm thinking about how to combine this with allowing non-panic failpoints
ivanvc
added a commit
to ivanvc/etcd
that referenced
this pull request
Feb 20, 2024
Fixes the incorrect backport of WaitLeader, as spawnJsonCmd expects an expected output string as argument, which wasn't provided in the first backport implementation. Original backport of commit 371179e from PR etcd-io#14752. Signed-off-by: Ivan Valdes <ivan@vald.es>
ivanvc
added a commit
to ivanvc/etcd
that referenced
this pull request
Feb 20, 2024
Fixes the incorrect backport of WaitLeader, as spawnJsonCmd expects an expected output string as argument, which wasn't provided in the first backport implementation. Original backport of commit 371179e from PR etcd-io#14752. Signed-off-by: Ivan Valdes <ivan@vald.es>
ivanvc
added a commit
to ivanvc/etcd
that referenced
this pull request
Feb 20, 2024
Fixes the incorrect backport of WaitLeader, as spawnJsonCmd receives an expected output string as an argument, which wasn't provided in the first backport implementation. Original backport of commit 371179e from PR etcd-io#14752. Signed-off-by: Ivan Valdes <ivan@vald.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14726
cc @ahrtr